[PATCH] D105432: [Analysis] Add simple cost model for strict (in-order) reductions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 09:14:02 PDT 2021


RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1170
 
+  enum class ReductionType : uint8_t { Split, Ordered };
+
----------------
Please can you add doxygen description comments for these?


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1177
   /// can either be a pairwise reduction or a reduction that splits the vector
   /// at every reduction level.
   ///
----------------
This comment still discusses pairwise reduction modes, but doesn't mention RedType


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105432/new/

https://reviews.llvm.org/D105432



More information about the llvm-commits mailing list