[PATCH] D105292: [NFC] Mark Expected<T>::assertIsChecked() as const

[xndcn via Phabricator via llvm-commits]

xndcn updated this revision to Diff 356973.
xndcn added a comment.

@sammccall Thanks! Fixed 3 typo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105292/new/

https://reviews.llvm.org/D105292

Files:
  llvm/include/llvm/Support/Error.h
  llvm/unittests/Support/ErrorTest.cpp


Index: llvm/unittests/Support/ErrorTest.cpp
===================================================================
--- llvm/unittests/Support/ErrorTest.cpp
+++ llvm/unittests/Support/ErrorTest.cpp
@@ -556,7 +556,7 @@
 TEST(Error, UncheckedExpectedInSuccessModeDestruction) {
   EXPECT_DEATH({ Expected<int> A = 7; },
                "Expected<T> must be checked before access or destruction.")
-    << "Unchecekd Expected<T> success value did not cause an abort().";
+      << "Unchecked Expected<T> success value did not cause an abort().";
 }
 #endif
 
@@ -565,9 +565,13 @@
 // Test runs in debug mode only.
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
 TEST(Error, UncheckedExpectedInSuccessModeAccess) {
-  EXPECT_DEATH({ Expected<int> A = 7; *A; },
-               "Expected<T> must be checked before access or destruction.")
-    << "Unchecekd Expected<T> success value did not cause an abort().";
+  EXPECT_DEATH(
+      {
+        const Expected<int> A = 7;
+        *A;
+      },
+      "Expected<T> must be checked before access or destruction.")
+      << "Unchecked Expected<T> success value did not cause an abort().";
 }
 #endif
 
@@ -576,9 +580,13 @@
 // Test runs in debug mode only.
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
 TEST(Error, UncheckedExpectedInSuccessModeAssignment) {
-  EXPECT_DEATH({ Expected<int> A = 7; A = 7; },
-               "Expected<T> must be checked before access or destruction.")
-    << "Unchecekd Expected<T> success value did not cause an abort().";
+  EXPECT_DEATH(
+      {
+        Expected<int> A = 7;
+        A = 7;
+      },
+      "Expected<T> must be checked before access or destruction.")
+      << "Unchecked Expected<T> success value did not cause an abort().";
 }
 #endif
 
Index: llvm/include/llvm/Support/Error.h
===================================================================
--- llvm/include/llvm/Support/Error.h
+++ llvm/include/llvm/Support/Error.h
@@ -670,7 +670,7 @@
   }
 #endif
 
-  void assertIsChecked() {
+  void assertIsChecked() const {
 #if LLVM_ENABLE_ABI_BREAKING_CHECKS
     if (LLVM_UNLIKELY(Unchecked))
       fatalUncheckedExpected();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105292.356973.patch
Type: text/x-patch
Size: 2107 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210707/a9530a1a/attachment.bin>