[PATCH] D105168: [RISCV] Unify the arch string parsing logic to to RISCVArchStringParser.

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 01:09:32 PDT 2021


kito-cheng updated this revision to Diff 356890.
kito-cheng added a comment.

Changes:

- Rebase to master, resolve conflict for zvamo change.
- New function filterSupportedExtensionInfosByName to simplify itearting SupportedExtensionInfos.
- Remove RISCVTargetInfo::HasA, look-up ISAInfo instead.
- Change retrun type for `RISCVISAInfo::parse(unsigned XLen, const std::vector<std::string> &Features)` to void, the only error is the XLEN checking, remove that and and add assertion instead.
- Address @craig.topper's comment
- Address @jrtc27's comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168

Files:
  clang/lib/Basic/Targets/RISCV.cpp
  clang/lib/Basic/Targets/RISCV.h
  clang/lib/Driver/ToolChains/Arch/RISCV.cpp
  clang/test/Driver/riscv-arch.c
  llvm/include/llvm/Support/RISCVISAInfo.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/RISCVISAInfo.cpp
  llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  llvm/test/MC/RISCV/attribute-arch.s
  llvm/test/MC/RISCV/attribute-with-insts.s
  llvm/test/MC/RISCV/invalid-attribute.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105168.356890.patch
Type: text/x-patch
Size: 67217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210707/bb11452a/attachment.bin>


More information about the llvm-commits mailing list