[PATCH] D105453: [mlir][System_Z] Disable `-fno-semantic-interposition` option.

[Haruki Imai via Phabricator via llvm-commits]

imaihal updated this revision to Diff 356888.
imaihal added a comment.

Condition to disable the option was updated since We found GCC version >= 11 is no problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105453/new/

https://reviews.llvm.org/D105453

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake


Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -318,8 +318,12 @@
     # Older Clang may support -fno-semantic-interposition but it used local
     # aliases to optimize global variables, which is incompatible with copy
     # relocations due to -fno-pic.
-    if (CMAKE_COMPILER_IS_GNUCXX OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND
-        CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 13))
+    # GCC for SystemZ: Enable `-fno-semantic-interposition` when using
+    # GCC version >= 11 in MLIR build. Old versions of GCC seems to have bugs.
+    if ((CMAKE_COMPILER_IS_GNUCXX AND
+	  NOT (LLVM_NATIVE_ARCH STREQUAL "SystemZ" AND "mlir" IN_LIST LLVM_ENABLE_PROJECTS
+            AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11))
+	OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 13))
       add_flag_if_supported("-fno-semantic-interposition" FNO_SEMANTIC_INTERPOSITION)
     endif()
   endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105453.356888.patch
Type: text/x-patch
Size: 1101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210707/e01fc523/attachment.bin>