[PATCH] D105524: [FuncSpec] Extract the analysis part as an analysis pass

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 00:54:04 PDT 2021


SjoerdMeijer added a comment.

I don't know much/anything about ThinLTO, which is why I don't really get what problem we need to solve:

> And if we want to make ThinLTO importer knows the information used by function specialization, we need to extract the analysis part

But before we go down the path of making a lot of changes, I think it would be best if we are reasonably confident this is the right approach, which we can achieve by adding reviewers familiar with the ThinLTO challenges and by posting follow up patches using this work. Like I said, I don't know much about the ThinLTO pipeline, perhaps @fhahn can recommend someone.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105524/new/

https://reviews.llvm.org/D105524



More information about the llvm-commits mailing list