[PATCH] D100375: [yaml2obj] Enable support for parsing 64-bit XCOFF.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 7 00:38:21 PDT 2021
jhenderson added a comment.
Looks good barring a nit, from my point of view, but you should get someone who knows the XCOFF file format better to review this to ensure the content is correct and tested satisfactorily.
================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:78
bool XCOFFWriter::nameShouldBeInStringTable(StringRef SymbolName) {
- return SymbolName.size() > XCOFF::NameSize;
+ // For XCOFF64: The symbol name is always in string table.
+ return (SymbolName.size() > XCOFF::NameSize) || Is64Bit;
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100375/new/
https://reviews.llvm.org/D100375
More information about the llvm-commits
mailing list