[PATCH] D104646: [AIX][XCOFF] 64-bit relocation reading support

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 7 00:32:27 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:334
+    if (Error E = RelocationsOrErr.takeError()) {
+      // TODO report the error up the stack
+      consumeError(std::move(E));
----------------
Nit: The common pattern is `// TODO: <some text>.` (note the colon, also it's a comment, so should have a trailing '.').

Same below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104646/new/

https://reviews.llvm.org/D104646



More information about the llvm-commits mailing list