[PATCH] D105433: [AArch64][GlobalISel] Lower vector types for min/max

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 23:33:49 PDT 2021


aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:173
+      .lowerIf([=](const LegalityQuery &Q) { return Q.Types[0].isScalar(); })
+      .lowerIf([=](const LegalityQuery &Q) { return Q.Types[0].isVector(); });
 
----------------
paquette wrote:
> I think you can use the helper functions in LegalizerInfo.h here to make this a little cleaner:
> 
> ```
>  .lowerIf(any(isScalar(0), isVector(0)))
> ```
At this point, the rule just becomes equivalent to `lower()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105433/new/

https://reviews.llvm.org/D105433



More information about the llvm-commits mailing list