[PATCH] D105525: [GISel] Add fpext/fptrunc combines

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:333
+                                     std::tuple<Register, unsigned> &MatchInfo);
+  bool applyCombineFPTruncIntToFloat(MachineInstr &MI,
+                                     std::tuple<Register, unsigned> &MatchInfo);
----------------
The apply functions should return void.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:473
+         [{ return Helper.matchCombineFPTruncExt(*${root}, ${matchinfo}); }]),
+  (apply [{ return Helper.replaceSingleDefInstWithReg(*${root}, ${matchinfo}); }])
+>;
----------------
likewise, the apply clause doesn't need to return.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105525/new/

https://reviews.llvm.org/D105525