[PATCH] D100735: [CodeGen] Enable Windows exception handling for basic block sections

Tue Jul 6 20:42:36 PDT 2021

TaoPan added a comment.

In D100735#2860997 <https://reviews.llvm.org/D100735#2860997>, @modimo wrote:

> In D100735#2846280 <https://reviews.llvm.org/D100735#2846280>, @TaoPan wrote:
>
>>   D99487 (parent of the below two patches): BBS basic function on Windows
>>   D100735 (this patch):  BBS exception handling on Windows
>>   D101421: BBS DebugInfo on Windows
>
> Is the plan to commit all of this at once?

Yes.
Could you please review this commit further?

================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:3202

+  // WinException::beginFunclet() set CurrentFuncletTextSection as
+  // Asm->OutStreamer->getCurrentSectionOnly(), start new funclet after
----------------
modimo wrote:
> How does this change interact with the ELF beginFunclet/endFunclet? 
No impact.
The ELF child classes of class EHStream don't override beginFunclet/endFunclet, refer to llvm/lib/CodeGen/AsmPrinter/DwarfException.h, class DwarfCFIExceptionBase, DwarfCFIException, ARMException.
Only class WinException override beginFunclet/endFunclet of class EHStream, refer to llvm/lib/CodeGen/AsmPrinter/WinException.h, class WinException.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100735/new/

https://reviews.llvm.org/D100735