[PATCH] D105217: [LLD] Adding support for RELA for CG Profile.

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 16:24:26 PDT 2021


ayermolo added a comment.

In D105217#2860864 <https://reviews.llvm.org/D105217#2860864>, @MaskRay wrote:

> You also need a yaml2obj test case. This is adding new functionality. Any such patch needs a test case.
>
>> Oh. I see. Something like this? I guess downside is that linking time will go up slightly because we have to scan through all the sections again.
>
> Yes, this is close. See my inline comment. The downside is likely negligible if you benchmark it... sizeof(InputSection) is ~184 bytes. I would be unhappy if the relatively minor feature takes 15% of its size.

Wanted to make sure it's on correct path, before adding tests, and elfDumper needs to be modified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105217/new/

https://reviews.llvm.org/D105217



More information about the llvm-commits mailing list