[PATCH] D105217: [LLD] Adding support for RELA for CG Profile.

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added a comment.

In D105217#2860630 <https://reviews.llvm.org/D105217#2860630>, @MaskRay wrote:

> My main concern has always been: I am not sure `ArrayRef<Elf_Rel> cgProfileRel; ArrayRef<Elf_Rela> cgProfileRela;` is the correct design.
>
> Previously I was ok because one ArrayRef just added 16 bytes. Now you are taking extra 16 bytes from each InputFile. Given the tiny benefit of this call graph profile optimization, I am not sure this is the good traceoff.
>
> Can't you just not cache `cgProfileRela`?

Oh. I see. Something like this? I guess downside is that linking time will go up slightly because we have to scan through all the sections again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105217/new/

https://reviews.llvm.org/D105217