[PATCH] D105288: [coro async] Cap the alignment of spilled values (vs. allocas) at the max frame alignment

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 14:29:16 PDT 2021


rjmccall added a comment.

Minor style request, but otherwise LGTM



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1565
     Value *Def = E.first;
+    auto TyAlignment = Align(FrameData.getAlign(Def));
     // Create a store instruction storing the value into the
----------------
I would assume from the name that this is something like the alignment of the type.  Maybe `SpillAlignment`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105288/new/

https://reviews.llvm.org/D105288



More information about the llvm-commits mailing list