[PATCH] D105484: [TTI] Remove IsPairwiseForm from getArithmeticReductionCost

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Still looking over the diffs, but this looks like a nice cleanup. 
The changes I made to SLP reductions a few months back removed the reduction implementation details from the pass; not propagating that up to the cost model was a follow-up that I didn't get around to.



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:1173-1175
   /// value using the operation denoted by \p Opcode. The form of the reduction
   /// can either be a pairwise reduction or a reduction that splits the vector
   /// at every reduction level.
----------------
Need to update this comment block. IIUC, the target override can decide the patterns based on whatever form(s) it supports, but that's a target-specific detail that doesn't need to be exposed to the callers (vectorizers) now that we have reduction intrinsics.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105484/new/

https://reviews.llvm.org/D105484