[PATCH] D105008: [VPlan] Add recipe for first-order rec phis, make splicing explicit.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4221
+  Value *Incoming = UF == 0 ? VecPhi : State.get(PreviousDef, UF - 1);
   VecPhi->addIncoming(Incoming, LI->getLoopFor(LoopVectorBody)->getLoopLatch());
 
----------------
Can RecipeBuilder.fixHeaderPhis() hook up to LastPrevious incoming across the backedge?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:692
+
+    Value *Incoming = Part == 0 ? State.get(getOperand(0), Part)
+                                : State.get(getOperand(1), Part - 1);
----------------
Worth a comment regarding Incoming (V1?) for first Part == 0, that getOperand(0) == RecurPHI has only a single Part, hence we get it's single Part 0 from State?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105008/new/

https://reviews.llvm.org/D105008