[PATCH] D105398: [SCEVExpander] Support opaque pointers

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 12:49:48 PDT 2021


dblaikie added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp:642
       Casted = InsertNoopCastOfTo(Casted, PTy);
-    Value *GEP = Builder.CreateGEP(OriginalElTy, Casted, GepIndices, "scevgep");
+    Value *GEP = Builder.CreateGEP(PTy->getElementType(), Casted, GepIndices,
+                                   "scevgep");
----------------
can/should we avoid the use of `PointerType::getElementType` here by some means - preserving it through the various choices in the code above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105398/new/

https://reviews.llvm.org/D105398



More information about the llvm-commits mailing list