[PATCH] D105506: [LLD] [COFF] Avoid thread exhaustion on 32-bit Windows host

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D105506#2860570 <https://reviews.llvm.org/D105506#2860570>, @jeremyd2019 wrote:

> In D105506#2860558 <https://reviews.llvm.org/D105506#2860558>, @mstorsjo wrote:
>
>> @jeremyd2019 - You wouldn't happen to have a reasonbly sized testcase to link lying around that you could try to run and see if the performance difference is measurable (i.e. a built project with e.g. lots of loose object files)? (Running lld often is so fast so it's hard to even measure anything unless you're linking something on the scale of Chromium, but I think this optimization is kinda vital.)
>
> I'm not quite sure what you are getting at.  I know of several projects that crash before with 32-bit LLD but succeed after.  Generally when being built with higher `-j` options.

Not a testcase for whether this crashes or not, but to see how much the suggested fix regresses linking performance for such projects that do succeed even before this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105506/new/

https://reviews.llvm.org/D105506