[PATCH] D90345: [DebugInfo] Fix ICE in DwarfCompileUnit::constructSubprogramScopeDIE

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D90345#2853542 <https://reviews.llvm.org/D90345#2853542>, @scott.linder wrote:

> I finally got around to updating the tests, and ran into the issue of supporting old bitcode which lacks a `type:` for `DISubprogram`s
>
> The only way I can see of "upgrading" these bitcodes is to pick some arbitrary `DISubroutineType` to use in place of `null`, likely `!DISubroutineType(types: !{null})`. This isn't correct in any sense, but if we are going to require the `type:` field it seems like the best we can do.
>
> Thoughts?

Perhaps an empty types list, rather than a list containing a single null element? I guess an empty list corresponds to the "void()" type & that seems OK-ish?

I guess if we've been crashing on it previously, maybe it's OK not to make this backwards compatible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90345/new/

https://reviews.llvm.org/D90345