[PATCH] D105364: [lld-macho] Drop assertions that all symbols are in GOT

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 12:24:16 PDT 2021


int3 added a comment.

Got it, thanks for the explanation! In that case, can we have a separate file for this test, and include as a comment the build steps you used to make the YAML? The small repro case you described is good, though having the input be assembly instead of C would make for even more minimal YAML. Running this through llvm-mc and `ld -r` should do the trick:

  .text
  .globl _main
  _main:
  	.cfi_startproc
  	.cfi_def_cfa_offset 16
    .cfi_endproc
    nop

It's worth adding some of that detail to the commit message as well. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105364/new/

https://reviews.llvm.org/D105364



More information about the llvm-commits mailing list