[PATCH] D105407: [LangRef] Add elementtype attribute

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 12:19:45 PDT 2021


dblaikie added a comment.

General thought: This seems unfortunately open-ended & could be used to used more generally in a way that might defeat some of the goals of the opaque pointers work (eg: if this gets added to arbitrary functions/used by transformations, etc).

Could/should we limit this to only apply to intrinsics? And can we possibly make it so this is not visible on the function decl, so transformations can't accidentally start depending on its presence (this attribute only really describes a feature of the implementation of the function, right? Not any requirement on callers about how they call such a function (they could pass in whatever pointer they like/doesn't really matter what it points to))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105407/new/

https://reviews.llvm.org/D105407



More information about the llvm-commits mailing list