[PATCH] D104547: [langref] attempt to clarify semantics of inttoptr/ptrtoint for non-integral types

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 11:46:16 PDT 2021


reames added a comment.

Max, I see your comment, but I'm not going to act on them.   Your commenting on the section which is discussing implications, not specification.  The specification wording is two paragraphs earlier.

I'm now asking for a LGTM.  I think this is worthwhile, but this has hit the point of perfection being the enemy of the good in the review discussion.  I don't plan on further iterating this - I really don't care enough - so from a practical perspective, we either take the improvement or I abandon the review and move on.  I'll leave it up to reviewers which they'd desire.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104547/new/

https://reviews.llvm.org/D104547



More information about the llvm-commits mailing list