[PATCH] D105006: [NewPM] Handle passes with params in -print-before/-print-after

Tue Jul 6 11:38:33 PDT 2021

ychen added a comment.

In D105006#2857688 <https://reviews.llvm.org/D105006#2857688>, @bjope wrote:

> Seems like we agree that this only is a start (that we should follow up with fixes for other passes such as in D105007 <https://reviews.llvm.org/D105007>).
>
> And I'm well aware that the PassRegistry might be refactored completely in the future (but for example D97722 <https://reviews.llvm.org/D97722> isn't really moving forward). Fixing the current implementation like this might however show-case the need for a refactoring a bit more. And it also helps setting the requirement on the new solution (to avoid that we end up refactoring a broken implementation without also considering the currently missing use-cases).
>
> So what is the verdict on this patch?

Sounds reasonable to me.

================
Comment at: llvm/test/Other/print-before-after.ll:39
+; mapping, so we do not get the -print-before=unswitch printout here.
+; XXXCHECK-UNSWITCH: *** IR Dump Before SimpleLoopUnswitchPass on Loop at depth 1 containing
+; CHECK-UNSWITCH: *** IR Dump After SimpleLoopUnswitchPass on Loop at depth 1 containing
----------------
`XXXCHECK-UNSWITCH`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105006/new/

https://reviews.llvm.org/D105006