[PATCH] D105390: [X86] Lower insertions into upper half of an 256-bit vector as broadcast+blend (PR50971)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:18973
+          MayFoldLoad(N1)))) {
+      SDValue N1SplatVec = DAG.getNode(ISD::SPLAT_VECTOR, dl, VT, N1);
+      SmallVector<int, 8> BlendMask;
----------------
X86 doesn't use ISD::SPLAT_VECTOR. I think this should be DAG.getSplatBuildVector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105390/new/

https://reviews.llvm.org/D105390