[PATCH] D105482: [lld/mac] Partially implement -export_dynamic

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 09:32:07 PDT 2021


thakis added a comment.

In D105482#2860080 <https://reviews.llvm.org/D105482#2860080>, @tschuett wrote:

> Thats fine. But it is odd that you are not testing that you get the right symbols. You are testing that you get the right symbols and in a random order.
>
> The order should be an implementation detail.

Yes, but as said above there's no good way I know of to do an order-independent test that also makes sure that a given list of matches is exhaustive. If I used `CHECK-DAG` then FileCheck would allow interleaving non-matched lines silently as far as I know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105482/new/

https://reviews.llvm.org/D105482



More information about the llvm-commits mailing list