[PATCH] D105476: [lld/mac] Give several LTO tests an "lto-" prefix

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 09:29:42 PDT 2021


thakis updated this revision to Diff 356761.
thakis retitled this revision from "[lld/mac] Rename internalize.ll test to lto-internalize.ll" to "[lld/mac] Give several LTO tests an "lto-" prefix".
thakis added a comment.

In D105476#2859937 <https://reviews.llvm.org/D105476#2859937>, @int3 wrote:

> I intentionally omitted the `lto-` prefix from this (and several other tests) because it seemed redundant -- practically all our `.ll` tests are LTO tests. I guess that's not strictly true any more though given things like `lc-linker-option.ll`. There are also some LTO tests that do have the `lto-` prefix, so we're not consistent about it either. I guess it doesn't really matter which scheme we pick as long as we're consistent. So... if we are going to add said prefix, can we do it for all the other LTO tests as well?

I had tried that, but apparently did a very poor job. I had looked at `rg llvm-as lld/test/MachO`, `rg save-temps lld/test/MachO` but apparently not very closedly.

Now that I look through `lld/test/MachO/*.ll` I found several else. I did _not_ rename these files since they don't seem primarily LTO tests:

- lld/test/MachO/bitcode-bundle.ll
- lld/test/MachO/bitcode-nodatalayout.ll (…should this one be in invalid/?)
- lld/test/MachO/force-load-swift-libs.ll
- lld/test/MachO/lc-linker-option.ll


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105476/new/

https://reviews.llvm.org/D105476

Files:
  lld/test/MachO/codemodel.ll
  lld/test/MachO/cpu-string.ll
  lld/test/MachO/internalize.ll
  lld/test/MachO/linkonce.ll
  lld/test/MachO/lto-codemodel.ll
  lld/test/MachO/lto-cpu-string.ll
  lld/test/MachO/lto-internalize.ll
  lld/test/MachO/lto-linkonce.ll
  lld/test/MachO/lto-mattrs.ll
  lld/test/MachO/lto-module-asm.ll
  lld/test/MachO/lto-objc-arc-contract.ll
  lld/test/MachO/mattrs.ll
  lld/test/MachO/module-asm.ll
  lld/test/MachO/objc-arc-contract.ll






More information about the llvm-commits mailing list