[PATCH] D105482: [lld/mac] Partially implement -export_dynamic

Tue Jul 6 09:12:51 PDT 2021

thakis added a comment.

In D105482#2859995 <https://reviews.llvm.org/D105482#2859995>, @tschuett wrote:

> In D105482#2859987 <https://reviews.llvm.org/D105482#2859987>, @thakis wrote:
>
>> In D105482#2859951 <https://reviews.llvm.org/D105482#2859951>, @tschuett wrote:
>>
>>> In D105482#2859935 <https://reviews.llvm.org/D105482#2859935>, @thakis wrote:
>>>
>>>> Thanks!
>>>>
>>>> It _only_ passes with `%lld` :) (But only because ld uses a different symbol order.) I ran it with ld locally to verify that our list of exported symbols matches ld64 (…except for ordering). And then I forgot to undo it before uploading, but luckily the precommit bots caught it.
>>>
>>> Could you sort the symbols to make it independent of the order, i.e. it works with ld and lld?
>
> I though of something like `llvm-objdump ... | grep ... | sort` and then do FileCheck on the result.

That feels like a kludge :) I don't think having the test work with ld is important enough to resort to stuff like that. But maybe someone is motivated to add real support for this use-case to FileCheck.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105482/new/

https://reviews.llvm.org/D105482