[PATCH] D105249: [llvm-strip] Support grouped options in llvm-strip

[Daniel Rodríguez Troitiño via Phabricator via llvm-commits]

drodriguez added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/grouped-options.test:1-2
+# This test checks that both grouped and ungrouped options (-S -x and -Sx)
+# produce exactly the same result given the same input.
+#
----------------
jhenderson wrote:
> Up to you whether you bother fixing it now, but in the newer tests in the LLVM binutils, we tend to use `##` for comments, to help distinguish them from RUN and CHECK directives.
Thanks for the tip! I didn't noticed the pattern before. If I modify this file (or others) again, I will try to remember.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105249/new/

https://reviews.llvm.org/D105249