[PATCH] D105462: [X86] Add CRC32 feature.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:84
                                       "Enable SSE 4.2 instructions",
-                                      [FeatureSSE41]>;
+                                      [FeatureSSE41, FeatureCRC32]>;
 // The MMX subtarget feature is separate from the rest of the SSE features
----------------
tianqing wrote:
> craig.topper wrote:
> > Doesn't this make -mno-crc32 disable sse4.2? Is that what we want?
> > 
> > Or should we be doing this like popcnt where we loosely enable it at the end of X86TargetInfo::initFeatureMap
> It does. But it's not a big deal in this case. The scenario described in the commit message doesn't require crc32 capable to be disabled separately.
What does gcc do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105462/new/

https://reviews.llvm.org/D105462