[PATCH] D105031: [SLP]Fix non-determinism in PHI sorting.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 05:56:43 PDT 2021


ABataev added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/remark_unsupported.ll:5
 
 ; This type is not supported by SLP
+define i1 @test(x86_fp80* %i1, x86_fp80* %i2) {
----------------
RKSimon wrote:
> update this comment? SLP isn't vectorizing x86_fp80 but why are you having to change the test?
Previously root PHI nodes with x86_fp80 type were rejected during graph building, here we started to reject them earlier to avoid some extra work. This leads to the fact that the expected message won't be emitted for this test anymore, so have to rework the test to emit the message again, because we still may see it during graph building, if some instructions return x86_fp80 type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105031/new/

https://reviews.llvm.org/D105031



More information about the llvm-commits mailing list