[PATCH] D105113: [LV] Do cost comparison on InstructionCost directly.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In D105113#2847034 <https://reviews.llvm.org/D105113#2847034>, @dmgreen wrote:

> i64 for the type sounds OK to me. (The old methods was known not to overflow because of divideCeil being a int64_t and the other values being int32. But with saturation that should be fine now too)
>
> Does this mean that invalid costs now don't vectorize? (For an invalid vector cost). Is it possible to add a test for that?

Not yet, that requires a few more code-changes. The behaviour to avoid vectorization with Invalid costs is added in D105473 <https://reviews.llvm.org/D105473> (with corresponding tests and some logic to print out useful opt-remarks).

This patch is intended to be NFC (I'll add `NFCI` to the title of the patch)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105113/new/

https://reviews.llvm.org/D105113