[PATCH] D103865: [SystemZ] Generate XC loop for memset 0 of variable length.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 04:52:54 PDT 2021


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

See the minor comment inside.   Otherwise, this LGTM now.  Thanks!



================
Comment at: llvm/lib/Target/SystemZ/SystemZAsmPrinter.h:35
+      if (MCI_STI_A.second != MCI_STI_B.second)
+        return MCI_STI_A.second < MCI_STI_B.second;
+      const MCInst &A = MCI_STI_A.first;
----------------
This comparison might involve undefined behavior given that these aren't pointers into the same array.  Probably best to convert to uintptr_t before comparing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103865/new/

https://reviews.llvm.org/D103865



More information about the llvm-commits mailing list