[PATCH] D105413: [ARM] Add lowering of uadd_sat to uq{add|sub}8 and uq{add|sub}16

Tue Jul 6 02:23:42 PDT 2021

dmgreen added a comment.

In D105413#2859221 <https://reviews.llvm.org/D105413#2859221>, @therealprof wrote:

> In D105413#2859219 <https://reviews.llvm.org/D105413#2859219>, @dmgreen wrote:
>
>>> The opcode selection would be vastly more complex but I can certainly take on a rework of that function if desirable.
>>
>> Yeah, it sounds like it should share more code than it complicates finding the new opcode.
>
> Sorry I don't follow. Are you asking me to unify the functions or saying it's fine as is? 😅

Yep, unifying them sounds better to me. It looks like its should be possible to keep the complexity of the opcode check down, and then it's simpler overall with a single function.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105413/new/

https://reviews.llvm.org/D105413