[PATCH] D105453: [mlir][System_Z] Disable `-fno-semantic-interposition` option.

Haruki Imai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 6 01:08:42 PDT 2021


imaihal added a subscriber: MaskRay.
imaihal added a comment.

After D102453 <https://reviews.llvm.org/D102453>, MLIR installation test (`cmake --build . --target check-mlir`) issues 32 errors on SystemZ with GCC. This errors can be avoided by disabling `fno-semantic-interposition`.  I used g++ (Ubuntu 9.4.0-1ubuntu1~18.04) 9.4.0.

One of the errors is as follows. Also in other errors, operands seems to be broken.

  llvm-project/mlir/test/Conversion/GPUCommon/lower-memcpy-to-gpu-runtime-calls.mlir:13:11: error: 'llvm.getelementptr' op expected 1 or more operands
      %t1 = gpu.memcpy async [%t0] %dst, %src : memref<7xf32, 1>, memref<7xf32>

Following is generated inc file (`LLVMOps.cpp.inc`). I think the `operands` is broken, but when I inserted printf here, the error disappears.

  void GEPOp::build(::mlir::OpBuilder &odsBuilder, ::mlir::OperationState &odsState, Type resultType, ValueRange operands, ArrayRef<NamedAttribute> attributes ) {
      if (resultType) odsState.addTypes(resultType);
      odsState.addOperands(operands);
      for (auto namedAttr : attributes) {
        odsState.addAttribute(namedAttr.first, namedAttr.second);
      }
    
  }

Hi, @MaskRay This patch modifies your patch (D102453 <https://reviews.llvm.org/D102453>). Do you have any suggestions or comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105453/new/

https://reviews.llvm.org/D105453



More information about the llvm-commits mailing list