[PATCH] D105090: [ARM] Introduce MVEEXT ISel lowering
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 6 00:35:00 PDT 2021
dmgreen added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:9007
+ EVT ExtVT = ToVT.getHalfNumVectorElementsVT(*DAG.getContext());
+ if (ToVT.getScalarType() == MVT::i32 && FromVT.getScalarType() == MVT::i8)
+ ExtVT = MVT::v8i16;
----------------
samtebbs wrote:
> I think it would be useful to add a comment here explaining the intermediate extension.
I added a quick comment pointing to the larger comment above in LowerTruncate, as that one already covers both extending and truncating.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105090/new/
https://reviews.llvm.org/D105090
More information about the llvm-commits
mailing list