[PATCH] D105330: [llvm-nm] Switch command line parsing from llvm::cl to OptTable

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-nm/Opts.td:38
+def version : FF<"version", "Display the version">;
+def without_aliases : FF<"without-aliases", "Exclude aliases from output">, Flags<[HelpHidden]>;
+
----------------
jhenderson wrote:
> MaskRay wrote:
> > jhenderson wrote:
> > > I don't follow why you've hidden this option?
> > --without-aliases is currently hidden. It seems to be for debugging.
> > 
> > The name is confusing: it applies to just LLVM bitcode files but the documentation isn't clear about this fact.
> > 
> It's in the command guide text. Either we should remove it from there, or it should be visible in the help text.
Removed --without-aliases from `llvm/docs/CommandGuide/llvm-nm.rst`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105330/new/

https://reviews.llvm.org/D105330