[PATCH] D104964: [ms] [llvm-ml] Add support for numeric built-in symbols

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

lg



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3516
+      Sym->isVariable() ? dyn_cast_or_null<MCConstantExpr>(
+                              Sym->getVariableValue(/*SetUsed*/ false))
+                        : nullptr;
----------------
Why is this changing? If it's intentional, nit: Named parameter comment style in LLVM is `/*SetUsed=*/false` (ie with `=` and without space)


================
Comment at: llvm/test/tools/llvm-ml/variable_redef_errors.asm:11
+; CHECK: :[[# @LINE + 1]]:1: error: cannot redefine a built-in symbol
+ at Line equ 5
+
----------------
Can you add a line for `@Version` too? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104964/new/

https://reviews.llvm.org/D104964