[PATCH] D105452: [lld][MachO] Code cleanup

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 5 19:14:27 PDT 2021


alexander-shaposhnikov created this revision.
alexander-shaposhnikov added reviewers: lld-macho, thakis.
Herald added a reviewer: int3.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
alexander-shaposhnikov requested review of this revision.
Herald added a project: LLVM.

Make use of ArgList::getLastArgValue. NFC.

Test plan: make check-lld-macho


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105452

Files:
  lld/MachO/Driver.cpp


Index: lld/MachO/Driver.cpp
===================================================================
--- lld/MachO/Driver.cpp
+++ lld/MachO/Driver.cpp
@@ -1106,10 +1106,8 @@
 
   config->mapFile = args.getLastArgValue(OPT_map);
   config->outputFile = args.getLastArgValue(OPT_o, "a.out");
-  if (const Arg *arg = args.getLastArg(OPT_final_output))
-    config->finalOutput = arg->getValue();
-  else
-    config->finalOutput = config->outputFile;
+  config->finalOutput =
+      args.getLastArgValue(OPT_final_output, config->outputFile);
   config->astPaths = args.getAllArgValues(OPT_add_ast_path);
   config->headerPad = args::getHex(args, OPT_headerpad, /*Default=*/32);
   config->headerPadMaxInstallNames =


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105452.356587.patch
Type: text/x-patch
Size: 709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210706/e0a9aa34/attachment.bin>


More information about the llvm-commits mailing list