[PATCH] D105448: [lld/mac] Implement -umbrella

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1126
+    if (config->outputType != MH_DYLIB)
+      warn("-umbrella used, but not creating dylib");
+    config->umbrella = arg->getValue();
----------------
ld64 doesn't have this warning, but it seems maybe useful.

ld64 accepts the empty string as `-umbrella` flag and then writes an empty string to the load command. We silently ignore an empty arg. Writing an empty string to the output is never useful. We could warn on it, I suppose, but I don't know if that ever happens…


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105448/new/

https://reviews.llvm.org/D105448