[PATCH] D105031: [SLP]Fix non-determinism in PHI sorting.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8362
+            auto *NodeI1 = DT->getNode(I1->getParent());
+            auto *NodeI2 = DT->getNode(I2->getParent());
+            assert(NodeI1 && "Should only process reachable instructions");
----------------
Avoid auto


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/remark_unsupported.ll:5
 
 ; This type is not supported by SLP
+define i1 @test(x86_fp80* %i1, x86_fp80* %i2) {
----------------
update this comment? SLP isn't vectorizing x86_fp80 but why are you having to change the test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105031/new/

https://reviews.llvm.org/D105031