[PATCH] D105431: [LLD] Fix a padding bug in the old Mach-O backend in LLD.

Mon Jul 5 08:02:12 PDT 2021

sheredom added inline comments.

================
Comment at: lld/lib/ReaderWriter/MachO/MachONormalizedFile.h:264

+  uint32_t                    headerPad = 16 + 24; // Space for UUID + CODESIGN
+
----------------
tschuett wrote:
> could that be something like `headerPad = sizeof(xxx) + sizeof(yyy)`?
> 
I can't find anything in LLD that states the size of these sections (although from binary inspecting we could tell we needed 16 + 24 bytes).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105431/new/

https://reviews.llvm.org/D105431