[PATCH] D89009: Add version to libLLVM also on non-UNIX

Mon Jul 5 05:43:16 PDT 2021

hans added a comment.

In D89009#2857959 <https://reviews.llvm.org/D89009#2857959>, @mstorsjo wrote:

> In D89009#2857904 <https://reviews.llvm.org/D89009#2857904>, @hans wrote:
>
>> In D89009#2857310 <https://reviews.llvm.org/D89009#2857310>, @mati865 wrote:
>>
>>> In D89009#2857228 <https://reviews.llvm.org/D89009#2857228>, @mstorsjo wrote:
>>>
>>>> Yep. I guess the question mainly is if we'd want to make this an upstream thing, adding an `if(UNIX)` around the symlinks on lines 608-613 here, if windows packaging cases would want to omit them anyway?
>>>
>>> I have no idea about guidelines for Windows but it'd make sense for me.
>>
>> I don't know the details of this well enough. How many/what symlinks are we talking about here? If it would add a lot of binary size to the install (since the symlinks would end up being full copies on Windows) it would be nice to avoid, but if it's not big then it's not a problem.
>
> I think in practice, right now no files are affected in MSVC builds at all, as libLLVM isn’t built there. (But there are plans to make it buildable for MSVC configs so it might matter in the future.) The symlinked files are largish, ~50-100 MB. So maybe we should opt out from those symlinks for now, and reconsider if there’s a concrete case where they are needed?

Sounds good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89009/new/

https://reviews.llvm.org/D89009