[PATCH] D105350: [SVE] Fixed cast<FixedVectorType> on scalable vector in SelectionDAGBuilder::getUniformBase

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-masked-scatter.ll:76
 
+define i32 @masked_scatter_nxv4i32_nxvp0i32 () {
+; CHECK-LABEL: masked_scatter_nxv4i32_nxvp0i32:
----------------
nit: please rename it to something like `masked_scatter_splat_constant_pointer` to make it clear it is specifically testing a splat(constant) pointer.


================
Comment at: llvm/test/CodeGen/AArch64/sve-masked-scatter.ll:89-92
+vector.ph:
+  br label %vector.body
+
+vector.body:                                      ; preds = %vector.body, %vector.ph
----------------
The control-flow can be removed from this function.


================
Comment at: llvm/test/CodeGen/AArch64/sve-masked-scatter.ll:96
+    i32 4,
+    <vscale x 4 x i1> shufflevector (<vscale x 4 x i1> insertelement (<vscale x 4 x i1> undef, i1 true, i32 0), <vscale x 4 x i1> undef, <vscale x 4 x i32> zeroinitializer))
+  br label %vector.body
----------------
can this be passed in as an argument, e.g. `<vscale x 4 x i1> %pg`


================
Comment at: llvm/test/CodeGen/AArch64/sve-masked-scatter.ll:97
+    <vscale x 4 x i1> shufflevector (<vscale x 4 x i1> insertelement (<vscale x 4 x i1> undef, i1 true, i32 0), <vscale x 4 x i1> undef, <vscale x 4 x i32> zeroinitializer))
+  br label %vector.body
+}
----------------
remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105350/new/

https://reviews.llvm.org/D105350