[PATCH] D103629: [AArch64] Cost-model i8 vector loads/stores

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks. Nice change



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/extend-vectorization-factor-for-unprofitable-memops.ll:11
 ; CHECK-LABEL: @test_load_i8_store_i32(
-; CHECK-NOT: x i8>
+; CHECK:       x i8>
 ;
----------------
Can check for <4 x i8> specifically


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/interleaved-vs-scalar.ll:4-6
 ; This test shows extremely high interleaving cost that, probably, should be fixed.
 ; Due to the high cost, interleaving is not beneficial and the cost model chooses to scalarize
 ; the load instructions.
----------------
This comment looks old now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103629/new/

https://reviews.llvm.org/D103629