[PATCH] D104148: [LoopUtils] Fix incorrect RT check bounds for loop-invariant mem accesses

Mon Jul 5 02:08:40 PDT 2021

fhahn added a comment.

Thanks for the update. Makes sense to me, it would just be good to reduce the noise in the test diffs

================
Comment at: llvm/test/Transforms/LoopVectorize/invariant-store-vectorization.ll:366
 ; CHECK-NEXT:  entry:
-; CHECK-NEXT:    [[SMAX:%.*]] = call i64 @llvm.smax.i64(i64 [[N]], i64 1)
-; CHECK-NEXT:    [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[SMAX]], 4
----------------
It’s hard to tell if there are actual IR changes in the test. Could you make sure only actual changes to the IR are included in the diff and try to avoid the noise from various name changes in the auto generated tests? 

Same for some of the other tests

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104148/new/

https://reviews.llvm.org/D104148