[PATCH] D105199: [LoopVectorize] Fix scalable vector crash in VPReplicateRecipe::execute

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 5 01:29:48 PDT 2021


david-arm added a comment.

In D105199#2857606 <https://reviews.llvm.org/D105199#2857606>, @fhahn wrote:

> IIUC from the description, this recipe effectively either widens the instruction or just computes the first lane if it is uniform. Does it handle any other case?

Yes. If you look at the new scalarizeInstruction() it also broadcasts a value into a new instruction if the result is non-void and *all* operands are loop invariant. This is a it different to the original scalarizeInstruction function that simply creates a scalar instruction per lane, generating the same value each time. This tests the `extractvalue` case in one of the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105199/new/

https://reviews.llvm.org/D105199



More information about the llvm-commits mailing list