[PATCH] D105341: [SVE] Fix ShuffleVector cast<FixedVectorType> in truncateToMinimalBitwidths

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/scalable-trunc-min-bitwidth.ll:4
+define void @func(i8* %p, i8 %arg1, i64 %len) {
+; CHECK-LABEL: @func(
+; CHECK-NEXT:  entry:
----------------
I wonder if all these CHECK lines are needed here? For example, I'm not sure if it's necessary for this simple loop to show the blocks after `vector.body`?

Also, it looks like you have created the CHECK lines using this tool:

  llvm/utils/update_test_checks.py

which is absolutely fine! This is just for information really, but normally if we leave the CHECK lines unmodified we also leave in the comment at the top:

  ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py

That way it tells anyone who has to change this file that they can just re-run that script again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105341/new/

https://reviews.llvm.org/D105341