[PATCH] D104889: [llvm-strings] Switch command line parsing from llvm::cl to OptTable

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me, with one remaining suggestion.



================
Comment at: llvm/tools/llvm-strings/Opts.td:16
+def print_file_name : Flag<["--"], "print-file-name">, HelpText<"Print the name of the file before each string">;
+defm radix : Eq<"radix", "Print the offset within the file">;
+def version : FF<"version", "Display the version">;
----------------
Perhaps "Print the offset within the file, with the specified radix."?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104889/new/

https://reviews.llvm.org/D104889