[PATCH] D105222: [AMDGPU][Docs] Update Code Object V3 example to includes args section

Thu Jul 1 08:31:36 PDT 2021

scott.linder added a comment.

In D105222#2852102 <https://reviews.llvm.org/D105222#2852102>, @t-tye wrote:

> In D105222#2851208 <https://reviews.llvm.org/D105222#2851208>, @krzysz00 wrote:
>
>> My understanding of the documentation is that global_buffer causes the kernel launcher to put the argument into a buffer. Is that not the case?
>
> For compute we are not using buffers in the sense of graphics. I think buffer is more in the spirit (and was the original motivation for) the runtime managing OpenCL buffers.
>
> @kzhuravl or @scott.linder can you actually get a dump of a real HIP program to see what is being used? @yaxunl may also be able to advise.

We seem to generate the global_buffer kind for a HIP kernel with a pointer argument: https://gcc.godbolt.org/z/q71nfEs91

I also looked into the address_space question briefly, and at least our OpenCL runtime does not seem to support the generic address space on global_buffer arguments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105222/new/

https://reviews.llvm.org/D105222