[PATCH] D102300: [LoopInterchange] Check lcssa phis in the inner latch in scenarios of multi-level nested loops

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 4 23:37:28 PDT 2021


congzhe updated this revision to Diff 356436.
congzhe added a comment.

@Whitney  My last update replaced my original test case with the one you trimmed, and I also updated the code correspondingly since the trimmed test case is a doubly-nested loop, so I deleted the code that checks whether InnerLoop has inner loops. However, it results in several regression test failures with doubly-nested loops.

areInnerLoopLatchPHIsSupported() is supposed to work with multi-level nested loops where InnerLoop is a nested loop itself. So I have to use my original test case to prevent incorrectly catching doubly-nested loops in lit tests.

I'll appreciate it if you could let me know if the current version looks good to you. Thanks a lot!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102300/new/

https://reviews.llvm.org/D102300

Files:
  llvm/lib/Transforms/Scalar/LoopInterchange.cpp
  llvm/test/Transforms/LoopInterchange/innermost-latch-uses-values-in-middle-header.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102300.356436.patch
Type: text/x-patch
Size: 6059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210705/3705d357/attachment.bin>


More information about the llvm-commits mailing list