[PATCH] D104974: [doc]Added examples for generic opcodes

[PoojaYadav via Phabricator via llvm-commits]

pooja2299 added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:738
+.. code-block:: none
+  G_BRCOND %4, %bb.1
+
----------------
aemerson wrote:
> xgupta wrote:
> > Why 4 not 3 or 5 or maybe 0?
> I suggest %cond or %condition for this
ok thanks @aemerson 


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:754
+.. code-block:: none
+  G_BRJT %9(p0), %jump-table.0, %5(s64)
+
----------------
paquette wrote:
> We could add more descriptive names here, like @xgupta suggested.
> 
> I just copied these from GenericOpcodes.td. (Although I changed "`$tbl`" to "`ptr`" here because I think that's more beginner-friendly.)
Sure, I will change the unamed vregs to more descriptive names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104974/new/

https://reviews.llvm.org/D104974